-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Python models filtering outputs based on requested outputs #7338
Merged
+130
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
kthui
changed the title
test: Non-decoupled models should filter outputs based on requested outputs
test: Python models filtering outputs based on requested outputs
Jun 11, 2024
kthui
force-pushed
the
jacky-py-req-output
branch
from
June 11, 2024 01:09
6b4e556
to
303f4e3
Compare
kthui
force-pushed
the
jacky-py-req-output
branch
from
June 11, 2024 01:16
303f4e3
to
80238e0
Compare
Tabrizian
reviewed
Jun 11, 2024
rmccorm4
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Also need a sanity check that Confirmed L0_batcher passes same pipeline.L0_batcher
tests pass with the python_backend change as well
Tabrizian
previously approved these changes
Jun 11, 2024
rmccorm4
approved these changes
Jun 11, 2024
kthui
added a commit
that referenced
this pull request
Jun 12, 2024
rmccorm4
pushed a commit
that referenced
this pull request
Jun 14, 2024
nv-kmcgill53
pushed a commit
that referenced
this pull request
Jun 17, 2024
nv-kmcgill53
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add tests to establish the behavior of Python backend filtering outputs based on requested outputs from the client.
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/python_backend#366
Where should the reviewer start?
N/A
Test plan:
N/A
#15726534
#15745686
#15752015
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A